Add script that helps with preparing a library for release#1255
Draft
azeey wants to merge 1 commit intogazebo-tooling:masterfrom
Draft
Add script that helps with preparing a library for release#1255azeey wants to merge 1 commit intogazebo-tooling:masterfrom
azeey wants to merge 1 commit intogazebo-tooling:masterfrom
Conversation
Contributor
azeey
commented
Jan 30, 2025
azeey
commented
- Bumps the version CMakeLists
- Bumps the version package.xml if present
- Updates the changelog file
- Bumps the version CMakeLists - Bumps the version package.xml if present - Updates the changelog file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
caguero
requested changes
Feb 12, 2025
|
|
||
| new_version = [int(v) for v in previous_version.split(".")] | ||
| if bump == "major": | ||
| new_version[0] += 1 |
Contributor
There was a problem hiding this comment.
I think that when bumping the major version we also need to set minor and patch to 0. Same when bumping the minor version, we need to set patch to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.